NonZero (max & min) Proof #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
reviewed
Dec 2, 2024
tautschnig
approved these changes
Dec 4, 2024
carolynzech
previously approved these changes
Dec 5, 2024
carolynzech
dismissed
their stale review
Requesting another change before merge.
carolynzech
reviewed
Dec 5, 2024
| @@ -2265,3 +2265,69 @@ mod verify { | |||
| nonzero_check!(u128, core::num::NonZeroU128, nonzero_check_new_unchecked_for_u128); | |||
| nonzero_check!(usize, core::num::NonZeroUsize, nonzero_check_new_unchecked_for_usize); | |||
| } | |||
|
|
|||
| #[cfg(kani)] | |||
| mod macro_nonzero_check_max { | |||
There was a problem hiding this comment.
Nice! Last thing -- instead of having a module for each function, can you move all of these harnesses inside of mod verify? We're trying to keep a consistent format for these proofs across challenges, and that's how we've been doing it so far.
There was a problem hiding this comment.
I have done this in NonZero (rotate_left & rotate_right) Proof #202
There was a problem hiding this comment.
Sure, but could you please also do it here?
|
Closing because this work got incorporated into #202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #71 (Safety of NonZero)
We are looking for feedback on our proof for max and min.
This is the initial logic; we will add a macro to extrapolate for data types.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.