Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable harnesses that were blocked by Kani's spurious CEX #211

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

celinval
Copy link

@celinval celinval commented Dec 6, 2024

In #148 and #122, we had to comment out a few harnesses due to the issue model-checking/kani#3670. But now that the fix has been pushed, we can enable them.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval celinval requested a review from a team as a code owner December 6, 2024 04:03
@celinval celinval enabled auto-merge (squash) December 6, 2024 18:48
Copy link
Author

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Author

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run approvals workflow

@celinval celinval merged commit ee9b7c3 into model-checking:main Dec 6, 2024
9 checks passed
tautschnig added a commit to tautschnig/verify-rust-std that referenced this pull request Dec 10, 2024
With model-checking/kani#3670 having been
addressed we re-enabled harnesses in model-checking#211. Yet the comment explaining
previously-commented-out-harnesses stayed in place.

Removing it for it no longer applies.
@tautschnig tautschnig mentioned this pull request Dec 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 10, 2024
With model-checking/kani#3670 having been
addressed we re-enabled harnesses in #211. Yet the comment explaining
previously-commented-out-harnesses stayed in place.

Removing it for it no longer applies.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants