forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable harnesses that were blocked by Kani's spurious CEX #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires the fix from: - model-checking/kani#3670
feliperodri
approved these changes
Dec 6, 2024
qinheping
approved these changes
Dec 6, 2024
celinval
commented
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
celinval
commented
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run approvals workflow
tautschnig
added a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Dec 10, 2024
With model-checking/kani#3670 having been addressed we re-enabled harnesses in model-checking#211. Yet the comment explaining previously-commented-out-harnesses stayed in place. Removing it for it no longer applies.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
With model-checking/kani#3670 having been addressed we re-enabled harnesses in #211. Yet the comment explaining previously-commented-out-harnesses stayed in place. Removing it for it no longer applies. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #148 and #122, we had to comment out a few harnesses due to the issue model-checking/kani#3670. But now that the fix has been pushed, we can enable them.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.