Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect link for "Specification (Draft)" on nav bar #137

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

imfing
Copy link

@imfing imfing commented Jan 9, 2025

Fix a link that redirects to 404

Motivation and Context

After clicking this link on the navbar, it takes us to a 404 page.

image

image

How Has This Been Tested?

Run npm run serve:docs and observe the link takes us to the /specification/draft

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think we probably want to actually create a /draft alias, like /latest. This would make https://spec.modelcontextprotocol.io/draft a usable link (e.g., to send people), which is valuable.

Can you please update the PR to do that?

@imfing
Copy link
Author

imfing commented Jan 10, 2025

Thanks for the PR!

I think we probably want to actually create a /draft alias, like /latest. This would make https://spec.modelcontextprotocol.io/draft a usable link (e.g., to send people), which is valuable.

Can you please update the PR to do that?

@jspahrsummers thank you, that makes sense. I added the alias: 8e98e65

@imfing imfing requested a review from jspahrsummers January 10, 2025 17:14
Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@imfing
Copy link
Author

imfing commented Jan 19, 2025

@dsp-ant can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants