feat: basic Docker support #2040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IcculusC
commented
Dec 31, 2024
| ARG OS=linux | ||
| ARG ARCH=x64 | ||
|
|
||
| FROM ubuntu:24.10 AS dependencies |
There was a problem hiding this comment.
arbitrary base image
IcculusC
commented
Dec 31, 2024
| chmod +x dotnet-install.sh && \ | ||
| ./dotnet-install.sh --version ${DOTNET_VERSION} --architecture ${ARCH} --os ${OS} | ||
|
|
||
| ENV PATH $PATH:/root/.dotnet |
There was a problem hiding this comment.
we have to update the PATH here so the publish stage can run the dotnet commands it needs to run
IcculusC
commented
Dec 31, 2024
| ARG DOTNET_VERSION | ||
| ARG ARCH | ||
|
|
||
| ENV DOTNET_ROOT=/root/.dotnet |
There was a problem hiding this comment.
updating the PATH in the dependencies stage above doesn't enable the ModernUO binary to find that installation
instead, we have to set DOTNET_ROOT before we run the binary
IcculusC
commented
Dec 31, 2024
docker-compose.yml
Outdated
| volumes: | ||
| - "./Distribution/Saves:/bin/modernuo/Saves" | ||
| - "./Distribution/Configuration:/bin/modernuo/Configuration" | ||
| - "$UO_DIRECTORY:$UO_DIRECTORY" |
There was a problem hiding this comment.
tl;dr my UO directory is something like /Users/icculusc/Downloads/UO, so that's what it is in the modernuo.json from running it on the metal, this maps it directly to that directory, this is a bad solution to be fair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.