update(model_splitter.py): #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jlarsen-usgs
commented
Oct 31, 2023
jlarsen-usgs
commented
- add check for no boundary condition instances in list based input packages. Do not write package in this case
- update options setting routine to respect previously set options for split models
- remove maxbound variable from mapped_data for list based input packages. Allows for dynamic maxbound setting by flopy built ins
* add check for no boundary condition instances in list based input packages. Do not write package in this case * update options setting routine to respect previously set options for split models * remove maxbound variable from mapped_data for list based input packages. Allows for dynamic maxbound setting by flopy built ins
Codecov Report
@@ Coverage Diff @@
## develop #1994 +/- ##
=======================================
Coverage 72.7% 72.7%
=======================================
Files 258 258
Lines 58830 58839 +9
=======================================
+ Hits 42790 42797 +7
- Misses 16040 16042 +2
|
jdhughes-usgs
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.