Post release 3.5.0 reset #2018
Merged
Post release 3.5.0 reset #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use ndarray.item() to retrieve single elements * update gridutil get_disu_kwargs() docstrings
* fix character span reading tkstp with a regex match * skip particle information reading GW-Mass Budget Co-authored-by: Ralf Junghanns <ralf@junghanns.it>
* fix(test): should be a complete grid * fix(model grid): Always resync mf2005 grids * Revert "fix(model grid): Always resync mf2005 grids" * fix(grid idomain): grid idomain now defaults to all 1's for MF6 only * fix(notebook): notebook contained out of bounds cellid * fix(modelgrid): always force modelgrid to resync until an idomain array is provided --------- Co-authored-by: scottrp <45947939+scottrp@users.noreply.github.com>
* warn at init/load time if exe not found, raise error at model run time
Flopy allows some keywords to be excluded from recarrays, like "FILEIN". This fix makes sure that optional keywords, like "MIXED" are not excluded from recarrays. Since they are optional their presence adds information to the recarray and they therefore can not be excluded. Co-authored-by: scottrp <45947939+scottrp@users.noreply.github.com>
- tests for example in #1922
Release 3.4.2
* ContourSet.get_paths() returns one path per level * path may contain multiple disconnected components * walk contour components to determine connectivity
* fix(usg bcf) ksat util3d call --> util2d call Signed-off-by: Chris Nicol <chris.nicol@groundwaterlogic.com> * doc(modflow/sfr2) add sfr2 channel_geometry_data to docstring Signed-off-by: Chris Nicol <chris.nicol@groundwaterlogic.com> --------- Signed-off-by: Chris Nicol <chris.nicol@groundwaterlogic.com>
* consistent with MFSimulation verbosity defaults * use category=UserWarning for mbase.py warnings * closes #1817
* reproduce and fix provided 2D model * stub simpler parametrized 2D tests * add freyberg mf6/mf2005 comparison * move get_face into get_structured_faceflows * remove og repro (covered by parametrized test)
* previously omitted totim=0 if compact * add mf6 test case courtesy of mbakker * test mf2005 with compact/non-compact
Release 3.4.3
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2018 +/- ##
=========================================
+ Coverage 72.2% 72.8% +0.5%
=========================================
Files 256 259 +3
Lines 56112 59040 +2928
=========================================
+ Hits 40564 43004 +2440
- Misses 15548 16036 +488
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
developbranch frommasterfollowing release of 3.5.0. As mentioned in #2016, this is not as clean is it should usually be, sincemasterwas not merged back intodevelopfollowing 3.4.2 and 3.4.3.