[stdlib] Transition InlinedFixedVecor.type to CollectionElement
#3561
Conversation
rd4com
force-pushed
the
InlinedFixedVector_CollectionElement
branch
from
454037f to
2e75886
Compare
Signed-off-by: rd4com <144297616+rd4com@users.noreply.github.com>
rd4com
force-pushed
the
InlinedFixedVector_CollectionElement
branch
from
2e75886 to
0b6ed60
Compare
|
Would it be possible to use conditional conformance within |
| mutability: Bool, //, | ||
| type: CollectionElement, | ||
| static_size: Int, | ||
| lifetime: Lifetime[mutability].type, |
There was a problem hiding this comment.
Suggestion You'll need to rebase since s/Lifetime/Origin recently
| self.current_size = 0 | ||
| self.capacity = capacity | ||
|
|
||
| @always_inline | ||
| fn __init__(inout self, existing: Self): | ||
| fn __copyinit__(inout self, existing: Self): |
There was a problem hiding this comment.
Suggestion If you'd like, we could make this conform to ExplicitlyCopyable too.
|
|
||
| var vector = InlinedFixedVector[MyStruct, 16](1000) | ||
|
|
||
| # assert del |
There was a problem hiding this comment.
Suggestion Instead of having one long test function with these conceptual different cases, from a maintenance perspective and ease of readability for others, I'd recommend putting each of these test cases in their own function, like so:
def test_destructor():
...
def copy_constructor():
...
def test_move_constructor():
...
def test_move_constructor_no_dynamic():
...
and so on. Thoughts?
This commit is a possible transition for
InlinedFixedVector,changing it's
typeparameter fromAnyTrivialRegTypetoCollectionElement.It is for a feature request by @JoeLoser:
#3478
Not sure if it is exactly what you had in mind @JoeLoser,
but here is a possible implementation 👍