[stdlib] Add a new validate parameter to the b64decode() function
#3929
Conversation
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
msaelices
changed the title
validate parameter to the b64decode() function
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
stdlib/src/base64/base64.mojo
Outdated
| @parameter | ||
| if validate: | ||
| if n % 4 != 0: | ||
| raise Error("ValueError: Input length must be divisible by 4") |
There was a problem hiding this comment.
Suggestion Include the byte length value (n) in the error message.
stdlib/src/base64/base64.mojo
Outdated
| @parameter | ||
| if validate: | ||
| if a < 0 or b < 0 or c < 0 or d < 0: | ||
| raise Error("ValueError: Unexpected character encountered") |
There was a problem hiding this comment.
Suggestion Include the unexpected character value in the error message.
This may mean pulling the snippet out into a local function and call it for each of the values a, b, c, and d.
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Thanks. I've fixed both of them here: msaelices@c1873d6 Could you please TAL? |
Nice improvement, thanks! Syncing now. |
|
!sync |
modularbot
added
the
imported-internally
|
@msaelices do you mind rebasing with latest nightly so I can sync this? Thanks! |
done |
Matching the
validatebool argument in Python's base64.b64decode but a using comp time parameter so it will not add CPU cycles if validation is not needed.