[stdlib] Use named output for _ListIter __next__() method #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgreni
force-pushed
the
named-out-list-iter
branch
2 times, most recently
from
f633d35 to
0273855
Compare
Signed-off-by: Brian Grenier <grenierb96@gmail.com>
bgreni
force-pushed
the
named-out-list-iter
branch
from
0273855 to
29d992f
Compare
JoeLoser
approved these changes
Jan 15, 2025
|
!sync |
modularbot
added
the
imported-internally
|
Thank you! I didn't really get them at first, but I'm becoming quite fond of them! |
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
Jan 16, 2025
…(#53928) [External] [stdlib] Use named output for _ListIter __next__() method Add a trivial optimization to use a named output for the `__next__()` method in `_ListIter` to save a subtraction operation on every iteration Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com> Closes #3941 MODULAR_ORIG_COMMIT_REV_ID: 426ada8f07f91a0d14ffe0c6e77ae074405e52c2
|
Landed in add55a5! Thank you for your contribution 🎉 |
jjvraw
pushed a commit
to jjvraw/mojo
that referenced
this pull request
Jan 16, 2025
…(#53928) [External] [stdlib] Use named output for _ListIter __next__() method Add a trivial optimization to use a named output for the `__next__()` method in `_ListIter` to save a subtraction operation on every iteration Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com> Closes modular#3941 MODULAR_ORIG_COMMIT_REV_ID: 426ada8f07f91a0d14ffe0c6e77ae074405e52c2 Signed-off-by: Joshua James Venter <venter.joshua@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__next__()method in_ListIterto save a subtraction operation on every iteration