Add config files feature. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZolotukhinM
force-pushed
the
ZolotukhinM/stack/2
branch
from
be0613e to
8bb8e52
Compare
ZolotukhinM
force-pushed
the
ZolotukhinM/stack/2
branch
from
8bb8e52 to
1857244
Compare
laszlokindrat
approved these changes
Oct 6, 2024
src/stack_pr/cli.py
Outdated
Comment on lines
1327
to
1339
| config["DEFAULT"] = { | ||
| "common": { | ||
| "verbose": False, | ||
| "hyperlinks": True, | ||
| "keep-body": False, | ||
| "draft": False, | ||
| }, | ||
| "repo": { | ||
| "reviewer": None, | ||
| "remote": "origin", | ||
| "target": "main", | ||
| }, | ||
| } |
There was a problem hiding this comment.
Q: Aren't these defaults redundant with the ones above?
There was a problem hiding this comment.
Oh, good catch!
ZolotukhinM
force-pushed
the
ZolotukhinM/stack/2
branch
from
1857244 to
74708e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Add config files feature.
The allows to have a local config to customize defaults for CL options.
Closes #22.