Tests #4
Open
Tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l1va
suggested changes
Nov 21, 2019
README.md
Outdated
|
|
||
| ### Control in Gazebo | ||
| i followed this [tutorial](http://gazebosim.org/tutorials/?tut=ros_control)<br/> | ||
| this [repo](https://github.com/ros-simulation/gazebo_ros_demos.git) contain examples which they use in the above tutorial<br/> | ||
|
|
||
| ### adding camera | ||
| i followed this [Tutorial: Using Gazebo plugins with ROS](http://gazebosim.org/tutorials?tut=ros_gzplugins)<br/> |
There was a problem hiding this comment.
Please remove all build stuff. These files not needed to be in repo. And why camera PR is here too? Fix please.
There was a problem hiding this comment.
edited, but i don't know why some commits appear in the both PR (testes, camera)
There was a problem hiding this comment.
:( and now 557 files are changed. And after merge you will not see files because you removed them. You see both changes because you created your branch based on camera branch, but should be based on master.
There was a problem hiding this comment.
i didn't notice that, i will try to make it work
l1va
reviewed
Dec 4, 2019
|
|
||
| def test_if_publishes(self): | ||
| rospy.init_node('listener', anonymous=True) | ||
| rospy.Subscriber("world", Float64, self.callback) |
There was a problem hiding this comment.
hmm, seems you do not fully understand sense of integration testing.
| @@ -0,0 +1,18 @@ | |||
| #!/usr/bin/env python | |||
| import unittest | |||
| import rospy | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.