added code to parse xml file to csv output #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
matentzn
reviewed
Feb 24, 2022
| @click.option("--input", "-i", "in_file", required=True, | ||
| help="Path to csv file to be processed.", | ||
| type=click.Path(exists=True, dir_okay=False, readable=True)) | ||
| @click.option("--output-file", "-o", default="./output.xlsx", |
There was a problem hiding this comment.
default should be tsv (in particular, babelon conformant tsv), but no worries now :)
There was a problem hiding this comment.
I should have been more clear on the pull request comment and not include files that aren't finished, this PR is only for updating the xml parser code - notebook (I have not updated the CLI code yet). I will update this PR.
| """ | ||
| input = read_csv(in_file) | ||
| output = process_csv(input) | ||
| write_excel(output, out_file) |
There was a problem hiding this comment.
where are these methods defined? I dont see them in this PR?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.