Fix issue with parsing errors in Mapping agent #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caufieldjh
deleted the
52-mapping-agent-returns-jsondecodeerror-expecting-value-line-1-column-1-char-0
branch
|
Out of curiosity (so I can understand why others might do the same) - we create your own mapping/mapping set data classes? |
|
@matentzn do you mean instead of using the sssom mapping classes? No technical reason other than simplicity as far as I know, plus the fact that curategpt doesn't require mappings to be URI vs URI, so there's no guarantee it would be valid sssom. |
|
Ok thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLM was returning Markdown-formatted JSON, but that isn't valid JSON, so it failed to parse.