Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resources (Bang Our Own Drum) #463

Merged
merged 22 commits into from
Nov 21, 2023
Merged

Add Resources (Bang Our Own Drum) #463

merged 22 commits into from
Nov 21, 2023

Conversation

glass-ships
Copy link
Collaborator

@glass-ships glass-ships commented Nov 2, 2023

Addresses #348

  • Adds resources page and endpoint to router
  • Adds some icons
  • Need to figure out icons for ones that don't have one (maybe @vincerubinetti will have ideas) ((Mondo should get a textless version eventually, i just don't have illustrator))

@glass-ships glass-ships self-assigned this Nov 2, 2023
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for monarch-app canceled.

Name Link
🔨 Latest commit 142ea16
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/655ce17aa8686300087e12ee

@vincerubinetti
Copy link
Contributor

vincerubinetti commented Nov 2, 2023

There's color contrast problems here. Try adding these styles to the app icon component, under .custom:

filter: brightness(0);

@vincerubinetti
Copy link
Contributor

Otherwise this looks good and is how the other pages are done. I don't see anything that would be causing some icons to inconsistently load. It sounds like it might just be a bug with the vite hot-module reloading and the vite svg loader plugin. I don't see the behavior on the netlify preview.

@glass-ships
Copy link
Collaborator Author

Otherwise this looks good and is how the other pages are done. I don't see anything that would be causing some icons to inconsistently load. It sounds like it might just be a bug with the vite hot-module reloading and the vite svg loader plugin. I don't see the behavior on the netlify preview.

that might be true, i only noticed it locally anyway. thanks vince! i'll make those changes here shortly, then add the mondo icon when it comes in. any ideas about the ones that don't have logos? (like mapping commons, ontoGPT, etc)

@vincerubinetti
Copy link
Contributor

If you can't find logos anywhere on the internet, maybe just leave them as initials? (Just use a kebab-case icon name, without the file existing.)

@vincerubinetti
Copy link
Contributor

Screenshot 2023-11-03 at 1 05 08 PM

You'll also need to change the header breakpoint so this does not happen.

@glass-ships
Copy link
Collaborator Author

Screenshot 2023-11-03 at 1 05 08 PM You'll also need to change the header breakpoint so this does not happen.

any idea what i'm looking for in particular? sorry, i don't immediately follow

@vincerubinetti
Copy link
Contributor

$wrap in the header component. It is the screen width below which the header collapses into a smaller layout.

@glass-ships glass-ships changed the title Add Resources page Add Resources, Update Overview Nov 6, 2023
@glass-ships glass-ships mentioned this pull request Nov 13, 2023
@glass-ships glass-ships changed the title Add Resources, Update Overview Add Resources (Bang Our Own Drum) Nov 14, 2023
@sagehrke
Copy link
Member

sagehrke commented Nov 15, 2023

Thank you for this draft @glass-ships! A few updates to consider:

  • Can @monicacecilia write a blurb for the top explaining what Resources means a bit more than the one-liner currently on the preview? I am thinking something to the effect of "Monarch is more than the KG you see here...it is a whole compendium of resources for etc etc etc...find links to our flagship products app or GitHub repos below" Perhaps ending this paragraph with a button link to our awesome new detailed documentation that @matentzn is leading the charge on: https://monarch-initiative.github.io/monarch-documentation/
  • I suggest we remove "Monarch KG & API" and "Monarch App" buttons on this page. While they are flagship, the info these may provide could instead be embedded into the /About page since that is all about the Monarch App, if it isn't there already (we can make another ticket for this if it is agreed that they should move - don't worry about doing it here).
  • I am still contemplating if I like the look of the buttons that we don't have logos for. I'd like to hear other people's opinions.
  • Update the "Standard" title to be plural "Standards"

@glass-ships
Copy link
Collaborator Author

I suggest we remove "Monarch KG & API" and "Monarch App" buttons on this page. While they are flagship, the info these may provide could instead be embedded into the /About page since that is all about the Monarch App, if it isn't there already (we can make another ticket for this if it is agreed that they should move - don't worry about doing it here).

there isn't really information added by either of these buttons. the only thing we don't do in the /about section is link to the monarch-documentation site itself, which we could do. but the Sources button links to the ingest docs, and the API button links to the same docs as the resources/Monarch KG & API button.

tldr; i support removing them, and maybe adding somewhere a link to the pages formerly known as technical docs

Copy link
Contributor

@monicacecilia monicacecilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack! missed this one. 🙈

@monicacecilia
Copy link
Contributor

Dear @glass-ships 👀 👇

  • Can @monicacecilia write a blurb for the top explaining what Resources means a bit more than the one-liner currently on the preview? I am thinking something to the effect of "Monarch is more than the KG you see here...it is a whole compendium of resources for etc etc etc...find links to our flagship products app or GitHub repos below" Perhaps ending this paragraph with a button link to our awesome new detailed documentation that @matentzn is leading the charge on: https://monarch-initiative.github.io/monarch-documentation/

Regarding a blurb at the top, we can update the content later - it is not a blocker.

For later, we can add:

The Monarch Initiative is an international consortium that leads key global standards and semantic data integration technologies. Monarch resources and integrated data are also foundational to many downstream applications and contexts; we work closely with a variety of stakeholders and resource-development communities to capture feedback and make improvements.
To maximize utility and impact, the Monarch platform is composed of multiple open-source, open-access components. We promote provenance and transparency, enhanced use of standards and new technologies and improved data accessibility, end-user utility, and data submission. Below, we highlight a collection of our flagship projects. Learn more about the complete suite of Monarch resources on our organization's documentation pages.

  • I suggest we remove "Monarch KG & API" and "Monarch App" buttons on this page. While they are flagship, the info these may provide could instead be embedded into the /About page since that is all about the Monarch App, if it isn't there already (we can make another ticket for this if it is agreed that they should move - don't worry about doing it here).

Thank you. Let's keep them. It is not redundant, and if someone only visits this page, they will have a comprehensive overview. Thanks!

  • I am still contemplating if I like the look of the buttons that we don't have logos for. I'd like to hear other people's opinions.

They look okay. Let's keep them as is. We can ask Julie for more logos. Not a blocker.

@glass-ships
Copy link
Collaborator Author

I see an approval, but because we moved to pulling the contents for this page from monarch docs, we now need to make sure the content we need here exists in that repository.

What has been requested is:

Standards = [
    "Phenopackets",
    "SSSOM",
    "Mapping Commons"
]

Ontologies = [
    "HPO",
    "MONDO",
    "uPheno"
]

Tools = [
    "OAK",
    "OntoGPT",
    "CurateGPT",
    "LinkML",
    "Semsimian",
    "Exomiser",
    "LIRICAL"
]

While what currently exists in that repository does not match.

We'll need to make sure monarch docs is updated accordingly before we bring this PR in. Perhaps @matentzn can help with that process as he's taken on the task of implementing the generation of that document thus far

@matentzn
Copy link
Member

Don't worry, this list will change 5 times in the next months. SemSimian and OAK are missing for now but we can add them after the vote (more likely will be that they are not added, or that if they are added, 6 other things will be added alongside, like ODK).

@glass-ships glass-ships merged commit 6d0346e into main Nov 21, 2023
9 checks passed
@glass-ships glass-ships deleted the resources branch November 21, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants