-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resources (Bang Our Own Drum) #463
Conversation
✅ Deploy Preview for monarch-app canceled.
|
There's color contrast problems here. Try adding these styles to the app icon component, under filter: brightness(0); |
Otherwise this looks good and is how the other pages are done. I don't see anything that would be causing some icons to inconsistently load. It sounds like it might just be a bug with the vite hot-module reloading and the vite svg loader plugin. I don't see the behavior on the netlify preview. |
that might be true, i only noticed it locally anyway. thanks vince! i'll make those changes here shortly, then add the mondo icon when it comes in. any ideas about the ones that don't have logos? (like mapping commons, ontoGPT, etc) |
If you can't find logos anywhere on the internet, maybe just leave them as initials? (Just use a kebab-case icon name, without the file existing.) |
|
Thank you for this draft @glass-ships! A few updates to consider:
|
there isn't really information added by either of these buttons. the only thing we don't do in the /about section is link to the tldr; i support removing them, and maybe adding somewhere a link to the pages formerly known as technical docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack! missed this one. 🙈
Dear @glass-ships 👀 👇
Regarding a blurb at the top, we can update the content later - it is not a blocker. For later, we can add: The Monarch Initiative is an international consortium that leads key global standards and semantic data integration technologies. Monarch resources and integrated data are also foundational to many downstream applications and contexts; we work closely with a variety of stakeholders and resource-development communities to capture feedback and make improvements.
Thank you. Let's keep them. It is not redundant, and if someone only visits this page, they will have a comprehensive overview. Thanks!
They look okay. Let's keep them as is. We can ask Julie for more logos. Not a blocker. |
I see an approval, but because we moved to pulling the contents for this page from monarch docs, we now need to make sure the content we need here exists in that repository. What has been requested is:
While what currently exists in that repository does not match. We'll need to make sure monarch docs is updated accordingly before we bring this PR in. Perhaps @matentzn can help with that process as he's taken on the task of implementing the generation of that document thus far |
Don't worry, this list will change 5 times in the next months. SemSimian and OAK are missing for now but we can add them after the vote (more likely will be that they are not added, or that if they are added, 6 other things will be added alongside, like ODK). |
Addresses #348