Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional phenogrid fixes #943

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Additional phenogrid fixes #943

merged 2 commits into from
Jan 21, 2025

Conversation

ptgolden
Copy link
Member

Allow <b> tags in node labels (including phenogrid labels), and add appropriate keys for phenogrid row/column tooltips.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 13e5bd8
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/678fde3759a4730008938df2
😎 Deploy Preview https://deploy-preview-943--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.97%. Comparing base (b953722) to head (13e5bd8).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
+ Coverage   70.75%   70.97%   +0.21%     
==========================================
  Files          91       91              
  Lines        3084     3128      +44     
==========================================
+ Hits         2182     2220      +38     
- Misses        902      908       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@amc-corey-cox amc-corey-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patrick walked me through these. Looks good.

@ptgolden ptgolden merged commit 3799a51 into main Jan 21, 2025
11 checks passed
@ptgolden ptgolden deleted the additional-phenogrid-fixes branch January 21, 2025 21:23
@dpavam
Copy link

dpavam commented Jan 22, 2025

Hi @ptgolden, thanks for pushing these changes!
I was trying these on our website. The tooltips now transpose correctly, thanks!

As for the <b> tags, I have tried incorporating them on a local version of the website:
By passing <b>label</b> I get the following behaviour:

Screenshot 2025-01-22 at 12 12 08

The label inside the tooltip is in bold 👍 but the label on the y-axis prints the <b> tags instead of going bold.
Am I missing something else that I should pass to the phenogrid?

Not sure if this is something on my side, but I thought I should let you know before the release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants