Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended_prefix_map #396

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Add extended_prefix_map #396

merged 1 commit into from
Jan 19, 2024

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Jan 19, 2024

Changes

  • Add: extended_prefix_map to mondo.sssom.config.yml

@souzadevinicius FYI. We're moving from plain, flat, bijective prefix map to "extended prefix maps" which capture such things as prefix and URI prefix synonyms.

@@ -75,6 +75,274 @@ curie_map:
GC_ID: "http://purl.obolibrary.org/obo/mondo/mappings/unknown_prefix/GC_ID/"
SNOMEDCT_2010_1_31: "http://purl.obolibrary.org/obo/mondo/mappings/unknown_prefix/SNOMEDCT_2010_1_31/"

extended_prefix_map:
Copy link
Contributor Author

@joeflack4 joeflack4 Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to mondo.sssom.config.yml

I first was added this to #394 (see comment), but I think this is better as a standalone PR.

I added it within mondo.sssom.config.yml as opposed to a standalone file. I have no idea however if this could have unintended side effects, so another consideration is that I could make a separate file for the EPM entirely and load that instead.

I verified manually that there are no syntax errors by doing yaml.safe_load() and double checking the contents.

prefix_synonyms: []
uri_prefix: http://www.ebi.ac.uk/efo/EFO_
uri_prefix_synonyms: []
- prefix: HGNC
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URI prefix synonyms

For several namespaces/prefixes, such as HGNC, I've combined what were previously several prefixes in curie_map (e.g. HGNC and HGNC__2, etc) into 1 EPM entry, e.g.:

    uri_prefix_synonyms:
      - 'https://identifiers.org/hgnc:'
      - 'https://www.genenames.org/data/gene-symbol-report/#!/hgnc_id/HGNC:'

uri_prefix_synonyms:
- https://www.orpha.net/ORDO/Orphanet_
- http://purl.obolibrary.org/obo/Orphanet_
- prefix: oboInOwl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix synonyms

Handled these situations as well. oio is the only prefix synonym, which is on oboInOwl.

@joeflack4
Copy link
Contributor Author

@twhetzel @matentzn I'm going to merge this one now, as these are fairly simple changes and we have already discussed / reviewed in our last meeting and as part of #394. After merging, I'm going to rebase #394. Of course, if there's any further review you'd like to do, we can do that post-facto, and if you find anything that needs tweaking, I'll be sure to do in a subsequent PR!

@joeflack4 joeflack4 merged commit 76771d7 into main Jan 19, 2024
@joeflack4 joeflack4 deleted the epm branch January 19, 2024 21:59
@joeflack4 joeflack4 mentioned this pull request Jan 19, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant