Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the README.md #354

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Updated the README.md #354

merged 2 commits into from
Sep 10, 2024

Conversation

yaseminbridges
Copy link
Contributor

Updated the README.md to better introduce the project with some example usage

@yaseminbridges yaseminbridges linked an issue Sep 2, 2024 that may be closed by this pull request
--output-dir /vcf
```

See the [documentation](https://monarch-initiative.github.io/pheval/executing_a_benchmark/) for instructions on benchmarking and evaluating the performance of various VGPAs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link leads to a 404 :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link will work once #348 is merged

Copy link
Contributor

@julesjacobsen julesjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Can you update or fix the broken link on the last line of the README before merging.

@julesjacobsen
Copy link
Contributor

OK - please merge this once the tox conflict is fixed in #348

@yaseminbridges yaseminbridges merged commit 2bab105 into main Sep 10, 2024
5 checks passed
@yaseminbridges yaseminbridges deleted the 353-update-readmemd branch September 30, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README.md
2 participants