This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
Core: WIP rewrite of router context and RI + related fixes #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves TODOs + brings us closer to removing the singleton.
Also adds new filesystem util function.
and many TODOs.
Epoch getter and startup time are both uint64_t
- Clarifies ident creation logic without relying on interface members - Adds debug logging + TODOs
- related rewriting - context SSU caps fixes - zero initialize our SSU intro key - remove unnecessary address/port updating - add some logging, docs, and lots of TODOs
Note: template function was not needed afterall.
- coreVersion option was removed in 0.9.24 - adds RI options debug logging
anonimal
added a commit
that referenced
this pull request
Nov 27, 2017
771340f Core: default RI opts setter + remove deprecation (anonimal) 872c70e Core: rewrite RI address add'er (anonimal) 1f14b65 Core: context/RI trait and state refactor (anonimal) b254beb Core: fix description logging of SSU address key (anonimal) a2a49aa Core: new RI ctor + fixes + WIP context init rewrite (anonimal) 18aa94e Core: don't use interface for context initialization (anonimal) eb37e28 Core: return uint64_t for router uptime (anonimal) 32b9d7c Core: WIP rewrite of router initialization (anonimal) 55df5b9 Core: initial rewrite of router initialization (anonimal) af6c154 Core: refactor context into core namespace (anonimal)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #627 to make way for #350.
By submitting this pull-request, I confirm the following: