Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Core: use IPv6 address object when expected + add test cases #984

Merged
merged 4 commits into from
Jul 25, 2018
Merged

Core: use IPv6 address object when expected + add test cases #984

merged 4 commits into from
Jul 25, 2018

Conversation

anonimal
Copy link
Collaborator

By submitting this pull-request, I confirm the following:

  • I have read and understood the developer guide in kovri-docs.
  • I have checked that another pull-request for this purpose does not exist.
  • I have considered and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.
  • I give this submission freely under the BSD 3-clause license.

Resolves #840.

Note: this PR decided to side-step most of the pre-fork issues mentioned in #840 (comment) in favor of resolving a few immediate ones (including the adjusting of appropriate SSU packet size).

@anonimal anonimal mentioned this pull request Jul 24, 2018
Closed
@anonimal
Copy link
Collaborator Author

anonimal commented Jul 24, 2018 •
edited
Loading

Referencing #140 and #627.

@anonimal
Copy link
Collaborator Author

The tests' build only fails on machines that run old/stupidly old boost versions because of a boost bug. As you can also tell, the boost bug was fixed in recent versions.

Because of the abysmal state of monero-project/meta#252 and the general backend issues that have plagued Monero Project for years, I'm at a point where I really just don't care anymore. If someone wants me to care, speak up. Otherwise I'll assume I'm talking into a black hole.

The tests build fine and pass on sane systems, as do the live tests. This PR can be merged before the code freeze.

@danrmiller
Copy link

What version of boost is required for kovri? For monero it's 1.58.

@SRCoughlin
Copy link

Kovri also requires 1.58.

coneiric
coneiric reviewed Jul 25, 2018
View reviewed changes
Copy link
Contributor

@coneiric coneiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great. I have a PR to fix the test build on Boost 1.58 platforms in anonimal/kovri#5.

Live tests and unit-tests pass without the patch with latest Boost, and unit-tests pass with the patch (on Boost 1.58 systems).

coneiric and others added 2 commits July 25, 2018 22:02
@coneiric
Tests: RouterInfo: fixes for Boost macros
50815d4 
For some supported Boost versions, BOOST_CHECK_EQUAL and BOOST_CHECK_NE
macros have issues comparing nullptr. Issue affects Boost versions at
least up to 1.63.
@anonimal
Merge pull request #5 from coneiric/ri
099442b 
Tests: RouterInfo: fixes for Boost version compatibility
@anonimal anonimal merged commit 099442b into monero-project:master Jul 25, 2018
anonimal added a commit that referenced this pull request Jul 25, 2018
@anonimal
Merge pull request #984
373f7cc 
50815d4 Tests: RouterInfo: fixes for Boost macros (oneiric)
a383f48 Tests: add RI test cases for transports (anonimal)
9b553ae Core: use IPv6 address object when expected (anonimal)
@anonimal anonimal deleted the ri branch July 25, 2018 23:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coneiric coneiric coneiric left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RouterInfo: ensure return of ipv6-capable Address object when requested
4 participants
@anonimal @danrmiller @SRCoughlin @coneiric