DOCS-15441 mongosync read preference behavior #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-allen-mongo
approved these changes
Apr 9, 2024
source/reference/mongosync.txt
Outdated
| specify a read preference, ``mongosync`` uses the read preference | ||
| :readmode:`primaryPreferred` on the source cluster. | ||
|
|
||
| By default, ``mongosync`` uses the read preference :readmode:`primary` |
There was a problem hiding this comment.
I would remove "By default" here, because this kind of makes it read like users can modify the behavior.
Maybe we can say:
mongosync always uses the :readmode:primary read preference on the destination cluster, even if you manually specify a read preference for the destination cluster
kauboy26
approved these changes
Apr 9, 2024
edobranov
suggested changes
Apr 9, 2024
There was a problem hiding this comment.
This actually doesn't apply anymore with the recent 1.7.2 release (you should get a merge conflict if you rebase onto master): f25a642#diff-a61a44aa44c4308e9fcfa894effe294e608468bf2a1e3cf752da6b039ef5f2beR274-R279
We can close out this ticket as Won't Do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
On the source, mongosync uses the user specified read preference and uses the read preference PrimaryPreferred if they did not set any preference.
On the destination, mongosync overwrites the user specified read preference with Primary.
STAGING
https://preview-mongodbltranmdb2.gatsbyjs.io/cluster-sync/DOCS-15441/reference/mongosync/#read-preference
JIRA
https://jira.mongodb.org/browse/DOCS-15441
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=6615857d3a5920a291966d88
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?