Add Double::to_uint and Double::to_uint64

[tonyfettes]

closes #1416

[peter-jerry-ye-code-review]

‼️ This code review is generated by a bot. Please verify the content before trusting it.

Here are three potential issues or observations from the provided git diff output:

1. Inconsistent Handling of Negative Values in to_uint64:

   • In the Double::to_uint64 function, negative values are explicitly handled by returning 0UL. However, the documentation and implementation in double_to_int64_js.mbt and double_to_int64_native.mbt do not clearly explain why negative values are treated this way. This could lead to confusion for users expecting a different behavior (e.g., wrapping around or returning an error). Consider adding a note in the documentation to clarify this design decision.

2. Redundant Code in int64_js.mbt:

   • The MyInt64::from_double function was removed from int64_js.mbt but was re-added in double_to_int64_js.mbt. This duplication could lead to maintenance issues if the logic needs to be updated in the future. Consider consolidating the implementation in a single location to avoid redundancy.

3. Potential Overflow Risk in to_uint:

   • In the Double::to_uint function, the condition self >= 4294967295.0 is used to check if the value exceeds the maximum UInt value. However, floating-point comparisons can be tricky due to precision issues. For example, a value like 4294967295.0000001 might not be correctly identified as exceeding the limit. Consider using a safer comparison method or adding a comment to explain the potential edge cases.

These observations are intended to help improve the code's clarity, maintainability, and robustness.

[coveralls]

Pull Request Test Coverage Report for Build 4598

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 83.295%

---

Totals
Change from base Build 4596:	0.0%
Covered Lines:	4727
Relevant Lines:	5675

---

💛 - Coveralls