Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtp: cache regexes in memory for reuse #46

Merged
merged 1 commit into from
Nov 28, 2023
Merged

rtp: cache regexes in memory for reuse #46

merged 1 commit into from
Nov 28, 2023

Conversation

adamdecaf
Copy link
Member

Fixes: #45

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (957ae88) 84.86% compared to head (94a6826) 85.49%.

❗ Current head 94a6826 differs from pull request most recent head 36c4c28. Consider uploading reports for the commit 36c4c28 to get more accurate results

Files Patch % Lines
pkg/rtp/restrictions.go 83.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   84.86%   85.49%   +0.62%     
==========================================
  Files          12       12              
  Lines         185      193       +8     
==========================================
+ Hits          157      165       +8     
  Misses         24       24              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jerome-laforge
Copy link

LGTM

Thx!

@adamdecaf adamdecaf merged commit ebb92e9 into master Nov 28, 2023
6 checks passed
@adamdecaf adamdecaf deleted the cache-regexes branch November 28, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid recompile regex by caching
4 participants