Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include field names in Validate() errors #50

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

adamdecaf
Copy link
Member

Also check an invalid pacs.008

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bc3f22) 85.49% compared to head (8165768) 83.93%.

❗ Current head 8165768 differs from pull request most recent head ff7f60e. Consider uploading reports for the commit ff7f60e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   85.49%   83.93%   -1.56%     
==========================================
  Files          12       12              
  Lines         193      193              
==========================================
- Hits          165      162       -3     
- Misses         24       26       +2     
- Partials        4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamdecaf adamdecaf merged commit 2b83643 into master Dec 7, 2023
6 checks passed
@adamdecaf adamdecaf deleted the include-fieldnames branch December 7, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants