Skip to content

Commit

Permalink
Fix issue where phone numbers were wrongly considered invalid and not…
Browse files Browse the repository at this point in the history
… included
  • Loading branch information
jonesde committed Nov 18, 2018
1 parent a58e7bb commit 770af58
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions service/mantle/shippo/ShippoServices.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,7 @@ along with this software (see the LICENSE.md file). If not, see
<if condition="telecomNumber != null">
<service-call name="mantle.party.ContactServices.clean#TelecomNumber" out-map="tnCleanOut" out-map-add-to-existing="false"
in-map="[countryCode:telecomNumber.countryCode, areaCode:telecomNumber.areaCode, contactNumber:telecomNumber.contactNumber]"/>
<if condition="tnCleanOut.isValid != null &amp;&amp; !isValid">
<if condition="tnCleanOut.isValid != null &amp;&amp; !tnCleanOut.isValid">
<log level="warn" message="Shippo for Party ${partyId} found invalid PostalAddress TelecomNumber ${telecomNumber.countryCode}-${telecomNumber.areaCode}-${telecomNumber.contactNumber}, not using"/>
<set field="telecomNumber" from="null"/>
</if>
Expand All @@ -1151,7 +1151,7 @@ along with this software (see the LICENSE.md file). If not, see
<set field="telecomNumber" from="telecomInfo.telecomNumber"/>
<service-call name="mantle.party.ContactServices.clean#TelecomNumber" out-map="tnCleanOut" out-map-add-to-existing="false"
in-map="[countryCode:telecomNumber.countryCode, areaCode:telecomNumber.areaCode, contactNumber:telecomNumber.contactNumber]"/>
<if condition="tnCleanOut.isValid != null &amp;&amp; !isValid">
<if condition="tnCleanOut.isValid != null &amp;&amp; !tnCleanOut.isValid">
<log level="warn" message="Shippo for Party ${partyId} found invalid Party TelecomNumber ${telecomNumber.countryCode}-${telecomNumber.areaCode}-${telecomNumber.contactNumber}, not using"/>
<set field="telecomNumber" from="null"/>
</if>
Expand Down

0 comments on commit 770af58

Please sign in to comment.