Rename math operations #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
requested review from
Rubilmax,
MerlinEgalite and
Jean-Grimal
and removed request for
a team
MerlinEgalite
approved these changes
Dec 10, 2023
Rubilmax
approved these changes
Dec 11, 2023
Jean-Grimal
approved these changes
Dec 11, 2023
adhusson
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Agreed that current names are misleading. Not sure about the best new names.
- just
wMul(etc) makes sense because regular solidity regular division truncates. wMul[zero,0,etc](etc) is more explicit and probably better since those new names will coexist withwDivDown(uint)(etc).
MerlinEgalite
approved these changes
Dec 12, 2023
MerlinEgalite
approved these changes
Dec 12, 2023
|
conflicts :/ |
Rubilmax
approved these changes
Dec 12, 2023
…me-math-operations
Rubilmax
approved these changes
Dec 12, 2023
|
There are failing tests |
MerlinEgalite
approved these changes
Dec 12, 2023
Merged
StErMi
reviewed
Dec 19, 2023
| @@ -10,11 +10,13 @@ int256 constant WAD_INT = int256(WAD); | |||
| /// @custom:contact security@morpho.org | |||
| /// @notice Library to manage fixed-point arithmetic on signed integers. | |||
| library MathLib { | |||
| function wMulDown(int256 a, int256 b) internal pure returns (int256) { | |||
| /// @dev Returns the multiplication of `a` by `b` (in WAD) rounded towards 0. | |||
| function wMulTo0(int256 a, int256 b) internal pure returns (int256) { | |||
There was a problem hiding this comment.
My two cents/nitpick: using the full word "zero" would maybe be more clean.
- it's easy to get confused between char
0andoandO. Having "zero" directly in the name is also much more explicit - probably it's not comfortable to have a number inside a function when you need to type it
Note: The solidity style guide does not have a strong opinion about having numbers inside the function's name
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cantina issue #127.
The only places where this differs from rounding towards negative infinity are the following:
morpho-blue-irm/src/AdaptiveCurveIrm.sol
Line 123 in 73eddf9
morpho-blue-irm/src/AdaptiveCurveIrm.sol
Line 137 in 73eddf9
coeff.wMulDown(err)inmorpho-blue-irm/src/AdaptiveCurveIrm.sol
Line 179 in 73eddf9
Those all have a consistent effect: under-estimating the error. This is why I think that only renaming those functions is enough