Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(irm): speed is not constant #108

Merged
merged 4 commits into from
Dec 12, 2023
Merged

docs(irm): speed is not constant #108

merged 4 commits into from
Dec 12, 2023

Conversation

Rubilmax
Copy link
Contributor

@Rubilmax Rubilmax marked this pull request as ready for review December 11, 2023 16:48
@Rubilmax Rubilmax force-pushed the docs/speed-constant branch from 76bf28e to 9cbf8aa Compare December 11, 2023 17:02
@Rubilmax Rubilmax force-pushed the docs/speed-constant branch from 9cbf8aa to 3e7facd Compare December 12, 2023 09:38
@MerlinEgalite
Copy link
Contributor

conflicts :/

MathisGD
MathisGD reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get what was wrong, except maybe the "slightly"

@Rubilmax
Copy link
Contributor Author

I don't get what was wrong, except maybe the "slightly"

For example, as explained in the associated issue, when utilization is at 89% the speed starts to decrease and then when it goes above 90% starts to increase again

@MathisGD
Copy link
Contributor

so the rate is underestimated, as stated in the comment no ?

@Rubilmax Rubilmax force-pushed the docs/speed-constant branch from 3e7facd to 174936a Compare December 12, 2023 10:43
@Rubilmax Rubilmax merged commit 7f1ec18 into post-cantina Dec 12, 2023
3 checks passed
@Rubilmax Rubilmax deleted the docs/speed-constant branch December 12, 2023 12:52
@Rubilmax Rubilmax mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-Grimal Jean-Grimal Jean-Grimal approved these changes

@MathisGD MathisGD MathisGD approved these changes

@MerlinEgalite MerlinEgalite MerlinEgalite approved these changes

@adhusson adhusson adhusson approved these changes

@QGarchery QGarchery Awaiting requested review from QGarchery

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rubilmax @MerlinEgalite @MathisGD @adhusson @Jean-Grimal