Extract coeff computation in curve function
#59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MerlinEgalite
requested review from
Rubilmax,
Jean-Grimal,
QGarchery,
peyha and
MathisGD
and removed request for
a team
MerlinEgalite
changed the title
curve function
Merged
Rubilmax
approved these changes
Nov 6, 2023
QGarchery
approved these changes
Nov 6, 2023
Jean-Grimal
approved these changes
Nov 6, 2023
MerlinEgalite
force-pushed
the
refactor/curve
branch
from
c123cfd to
a136b50
Compare
MathisGD
reviewed
Nov 8, 2023
src/SpeedJumpIrm.sol
Outdated
| @@ -163,11 +164,9 @@ contract AdaptativeCurveIrm is IIrm { | |||
| /// r = ((1-1/C)*err + 1) * rateAtTarget if err < 0 | |||
| /// ((C-1)*err + 1) * rateAtTarget else. | |||
| function _curve(uint256 _rateAtTarget, int256 err) private view returns (uint256) { | |||
| uint256 steeringCoeff = err < 0 ? WAD - WAD.wDivDown(CURVE_STEEPNESS) : CURVE_STEEPNESS - WAD; | |||
There was a problem hiding this comment.
this is not the steering coefficient but the steering coefficient divided by _rateAtTarget.
There was a problem hiding this comment.
So what name do you suggest? just coeff? coeffAdjusted?
There was a problem hiding this comment.
Or we can divide by the denominator now
There was a problem hiding this comment.
yes but it's not readable to me
MerlinEgalite
force-pushed
the
refactor/curve
branch
from
a136b50 to
80e075e
Compare
Rubilmax
approved these changes
Nov 9, 2023
|
done in #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this suggestion.