-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme and fix license #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
requested review from
Rubilmax,
MerlinEgalite and
Jean-Grimal
and removed request for
a team
November 24, 2023 10:47
QGarchery
previously approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, everything is non-blocking
Rubilmax
previously approved these changes
Nov 24, 2023
MathisGD
commented
Nov 24, 2023
MathisGD
commented
Nov 24, 2023
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Rubilmax
suggested changes
Nov 27, 2023
MathisGD
commented
Nov 27, 2023
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
QGarchery
approved these changes
Nov 27, 2023
MerlinEgalite
approved these changes
Nov 27, 2023
Rubilmax
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16, and an issue in a licence, and a formatting issue after a forge release