[MVP]integrate LDAP as external auth service #2
Conversation
Makonike
changed the title
It will run in my repository, and you can find it there. |
| go-version: 1.19 | ||
|
|
||
| - name: build | ||
| run: make build |
There was a problem hiding this comment.
Also, need a better way to test other modes, now we could only test with simple static configuration.
we should test with different configuration modes, eventually, not a very high priority.
There was a problem hiding this comment.
I will fix this later.
| bind_dn: | ||
| bind_password: | ||
| # if the filter is set, the filter application will run in search mode. | ||
| filter: |
There was a problem hiding this comment.
better add an example config as demo, in comment could be good enough.
| bind_password: | ||
| # if the filter is set, the filter application will run in search mode. | ||
| filter: | ||
| timeout: 60 |
There was a problem hiding this comment.
add comment: unit is second.
| } | ||
|
|
||
| func (p *parser) Merge(parent interface{}, child interface{}) interface{} { | ||
| panic("TODO") |
There was a problem hiding this comment.
this TODO need to be addressed.
| func dial(config *config) (*ldap.Conn, error) { | ||
| return ldap.DialURL( | ||
| // TODO: support TLS | ||
| fmt.Sprintf("ldap://%s:%d", config.host, config.port), |
There was a problem hiding this comment.
use fmt for debug log is not a good idea, eventually. please use the HttpLog in filter.callbacks.
| func newLdapClient(config *config) (*ldap.Conn, error) { | ||
| client, err := dial(config) | ||
| if err != nil { | ||
| fmt.Println("ldap dial error: ", err) |
see #1 . This MVP version of LDAP integration as an external authentication service does not currently support TLS (Transport Layer Security). Other detailed explanations can be found in the README.md file.