Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support SubscribeTopicEvents API #1088

Merged
merged 5 commits into from
Dec 17, 2024
Merged

feat: Support SubscribeTopicEvents API #1088

merged 5 commits into from
Dec 17, 2024

Conversation

CrazyHZM
Copy link
Contributor

@CrazyHZM CrazyHZM commented Dec 9, 2024 •
edited by zhenjunMa
Loading 

Github Action Bot detected the issue body's language is not English, translate it automatically

What this PR does:

see #1074

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
原文

What this PR does:

see #1074

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


```</details>
<!--MD5:059efee4dbfad356df5d8122cd78c695:MD5-->

@CrazyHZM
feat: Support SubscribeTopicEvents API
00adaa3 
Signed-off-by: “huazhongming” <crazyhzm@apache.org>
@CrazyHZM
Merge branch 'main' into feat/support_SubscribeTopicEvents
54c765a 
# Conflicts:
#	sdk/go-sdk/client/client.go
@CrazyHZM
remove go sdk
530e88d 
Signed-off-by: “huazhongming” <crazyhzm@apache.org>
@CrazyHZM
remove subscribeTopicEvents API demo
744d3d7 
Signed-off-by: “huazhongming” <crazyhzm@apache.org>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Hi @CrazyHZM. Thanks for your PR! 🎉
If the PR is ready, use the /cc command to assign reviewer to review.

Details

The full list of commands accepted by this bot can be found here.

The pull request process is described here.

@CrazyHZM CrazyHZM force-pushed the feat/support_SubscribeTopicEvents branch 2 times, most recently from 01e1f1f to b96d072 Compare December 14, 2024 04:01
wenxuwan
wenxuwan requested changes Dec 16, 2024
View reviewed changes
pkg/grpc/default_api/api.go Outdated Show resolved Hide resolved
pkg/grpc/default_api/api_subscribe.go Outdated Show resolved Hide resolved
pkg/grpc/default_api/api_subscribe.go Show resolved Hide resolved
@CrazyHZM CrazyHZM force-pushed the feat/support_SubscribeTopicEvents branch from b96d072 to d4dda9b Compare December 16, 2024 14:32
@wenxuwan wenxuwan merged commit 20b531e into mosn:main Dec 17, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenxuwan wenxuwan wenxuwan approved these changes

Assignees
No one assigned
Labels
cla:yes size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrazyHZM @wenxuwan