Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal #123

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Modal #123

wants to merge 5 commits into from

Conversation

stevenyuen
Copy link
Contributor

@stevenyuen stevenyuen commented Feb 6, 2018 •
edited
Loading

  • Modal close button is based on Modal component's z-index. Updated styling of close button
  • Ability to set percentage-based width and height
  • closeURL prop not required if onClose func provided
  • Ability to set Overlay Background color/opacity
  • Use React Portals
  • Updated Docs

@stevenyuen stevenyuen requested a review from asabhaney February 28, 2018 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asabhaney asabhaney Awaiting requested review from asabhaney

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stevenyuen