Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to sort columns #253

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Add ability to sort columns #253

merged 4 commits into from
Jan 14, 2025

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Jan 13, 2025

Since mozilla/remote-settings#725 the list of collection is sorted by -last-modified

This PR makes the table headers clickable to sort the table

Screenshot 2025-01-13 at 12 00 41

@leplatrem leplatrem force-pushed the add-sortable-columns branch from 3e2ce84 to af1a305 Compare January 13, 2025 12:09
Copy link
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose making the cursor turn into a pointer when hovering over the sortable col headers. Added this to styling so if you agree we can merge.

@leplatrem
Copy link
Contributor Author

Good catch! Thanks!

@leplatrem leplatrem merged commit 3e2ade6 into master Jan 14, 2025
8 checks passed
@leplatrem leplatrem deleted the add-sortable-columns branch January 14, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants