Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1941649 - Grant generic action scopes for mozilla trust domain … #260

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

ahal
Copy link
Contributor

@ahal ahal commented Jan 14, 2025

…scm_level_*

@ahal ahal self-assigned this Jan 14, 2025
@ahal
Copy link
Contributor Author

ahal commented Jan 14, 2025

I'm going to leave this in draft until others on the team have had a chance to object.

@ahal ahal marked this pull request as ready for review January 15, 2025 14:49
@ahal ahal requested a review from a team as a code owner January 15, 2025 14:49
@ahal ahal force-pushed the ahal/push-kotkynrppzqy branch from ce7c566 to fc599c9 Compare January 15, 2025 14:49
Copy link
Contributor

@bhearsum bhearsum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at Gecko actions that are using the generic permission. The only one that seemed like it ought not to be usable by anyone with L3 is https://searchfox.org/mozilla-central/source/taskcluster/gecko_taskgraph/actions/openh264.py, which builds and signs the openh264 plugin. It's not like that actually ships anything though, so I'm not terribly concerned about it.

rebuild_cached_builds might arguably need to be more protected as well, but that's more for footgun reasons than anything else, and I can still see a fairly strong argument for keeping it generic to keep a wide array of people that can help unstick cached task issues.

@ahal
Copy link
Contributor Author

ahal commented Jan 16, 2025

Just to clarify, we already grant the generic Gecko permissions to everyone with L3 (I think you knew that). I agree that those two should probably have their own scope though.

@ahal ahal merged commit 448be0c into mozilla-releng:main Jan 16, 2025
7 checks passed
@ahal ahal deleted the ahal/push-kotkynrppzqy branch January 16, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants