Skip to content

Commit

Permalink
Add Fml versioning (#542)
Browse files Browse the repository at this point in the history
* Add FML version-based errors to the Q4 2023 whats newsletter

* Update experimenter branches doc to include fml version errors
  • Loading branch information
Elise Richards authored Dec 19, 2023
1 parent 1b5aded commit 8dcdd9f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions docs/deep-dives/experimenter/branches.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ For non-desktop applications, the Feature Manifest Language (FML) is used to sur

You can see that the save button validation has given us usable FML errors, including the line/col number that the error occurs at:

<img src="/img/deep-dives/deeply-nested-fml-error.png"/>
<img title="Deeply nested FML error" src="/img/deep-dives/deeply-nested-fml-error.png"/>

The FML generates errors based on the **feature** you are using, the **application**, and the **channel**. Changing the channel on your experiment may result in different FML errors, since there may be differences between the feature manifests for each channel.
<img title="FML Version error" src="/img/deep-dives/fml-version-error.png"/>

The FML generates errors based on the **feature** you are using, the **application**, the **versions** of the application that you are targeting, and the **channel**. Changing the channel on your experiment may result in different FML errors, since there may be differences between the feature manifests for each version and channel.


## Desktop
Expand Down
6 changes: 4 additions & 2 deletions docs/whats-news/2023/2023-q4.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Coming soon...

## Experimenter

🙌 FML error detection - [EXP-3873](https://mozilla-hub.atlassian.net/browse/EXP-3873), [EXP-2365](https://mozilla-hub.atlassian.net/browse/EXP-2365)
🙌 FML error detection

> Error detection using the Feature Manifest Language is now available in Experimenter! For all applications that utilize the FML (non-desktop apps), the "Branches" page now uses the FML to detect when a feature configuration is invalid for the application's feature manifest. This is especially useful for deeply nested feature configurations. (erichards)
> Error detection using the Feature Manifest Language is now available in Experimenter! For all applications that utilize the FML (non-desktop apps), the "Branches" page now uses the FML to detect when a feature configuration is invalid for the application's feature manifest. This is especially useful for deeply nested feature configurations. (erichards) [EXP-3873](https://mozilla-hub.atlassian.net/browse/EXP-3873), [EXP-2365](https://mozilla-hub.atlassian.net/browse/EXP-2365)
> The FML also detects errors based on the specified versions that have been ch sen. For example, if you are targeting Fenix version 120 and the feature configuration shows errors for that version, you will now get helpful error messages that tell you _which_ version(s) of the feature manifest are throwing these errors. (erichards) [EXP-3875](https://mozilla-hub.atlassian.net/browse/EXP-3875)
Binary file added static/img/deep-dives/fml-version-error.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 8dcdd9f

Please sign in to comment.