Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pinning versions of build and deploy tools (including tooling like pip) #367

Open
hwine opened this issue Oct 1, 2020 · 2 comments
Milestone

Comments

@hwine
Copy link
Contributor

hwine commented Oct 1, 2020

We just experienced an unexpected production breakage when a CI build may have used the new pip resolver. (i.e. broken by upstream software upgrade)

Currently, none of the build tooling is pinned. As we spread to more users, the blast radius of sudden failures expands.

One way to address only bump versions as part of a new release (that's been tested)

@g-k
Copy link
Contributor

g-k commented Oct 2, 2020

The python version is specified at https://github.com/mozilla/frost/blob/master/setup.py#L31

@hwine
Copy link
Contributor Author

hwine commented Oct 2, 2020

N.B. the original problem was not caused by any of the setup files -- it's this line in the Makefile.

Which isn't to say that poetry & lock files aren't a good thing :D they just wouldn't have prevented this issue.

@hwine hwine changed the title Consider pinning python versions (including tooling like pip) Consider pinning versions of build and deploy tools (including tooling like pip) Oct 2, 2020
@ajvb ajvb added this to the 0.6.0 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants