Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin python dependencies #373

Closed
wants to merge 1 commit into from
Closed

pin python dependencies #373

wants to merge 1 commit into from

Conversation

g-k
Copy link
Contributor

@g-k g-k commented Oct 2, 2020

Not best practice, but maybe it'll fix #367

Copy link
Contributor

@hwine hwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My $0.02

@@ -7,7 +7,7 @@
long_description = fh.read()

install_requires = [
line.split("==")[0] for line in open("requirements.txt", "r") if ".git" not in line
line for line in open("requirements.txt", "r") if ".git" not in line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this approach -- it's magic, and makes the production environment differ from dev, potentially leading to hard-to-debug conditions.

Since we've eliminated the repo reference from requirements.txt, I don't think this PR is needed at all.

Two thoughts if you do want to proceed:

  1. remove requirements from setup.py entirely, in favor of specifying as much as possible in pyproject.toml as proposed in add poetry lock and project files #372
  2. annotating this with a huge, ugly comment, so it's very obvious that magic is occuring.

@g-k g-k closed this Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider pinning versions of build and deploy tools (including tooling like pip)
2 participants