Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug links in platform health check #996

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix bug links in platform health check #996

merged 1 commit into from
Jan 9, 2025

Conversation

BenWu
Copy link
Contributor

@BenWu BenWu commented Jan 9, 2025

This makes the bug links in the health check dashboard clickable. I remember this working at some point last year but I don't know why it doesn't work anymore.

I verified this is working in development mode:
image

Checklist for reviewer:

When adding a new derived dataset:

  • Ensure that the data is not available already (fully or partially) and recommend extending an existing dataset in favor of creating new ones. Data may be available in bigquery-etl repository, looker-hub or in looker-spoke-default.
  • Avoid merging a PR that includes the logic of a core metric or complex business logic. The recommendation is to implement core business logic in bigquery-etl. E.g. The type of search or the calculation of DAU or visited URIs.
  • Avoid merging code in Looker Explores/Views that implement analysis with multiple lines of code or that will be likely replicated in the future. Instead, aim for extending an existing dataset to include the required logic, and use Looker aggregates to facilitate the analysis.
  • Avoid merging a PR with logic that requires validation and health checks. It is recommended to implement it in bigquery-etl for full test coverage and failure alerts.

{% if value != '' %}
{{ bug }}
{% endif %}"
url: "{{ bug }}"
Copy link
Contributor

@sean-rose sean-rose Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it was the extra whitespace/newlines in the value that were the problem? Does making the conditional a one-liner work?

Suggested change
url: "{{ bug }}"
url: "{% if value != '' %}{{ bug }}{% endif %}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work

image

@BenWu BenWu merged commit 2f87659 into main Jan 9, 2025
1 check passed
@BenWu BenWu deleted the benwu/fix-bug-link branch January 9, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants