Don't retrieve Tinderbox directory listing when timestamp is provided (#313) #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
requested changes
May 8, 2024
There was a problem hiding this comment.
With the patch applied it works great and removes a lot of work from the server. No new tests need to be added given that existing ones cover it well enough and cannot easily check that the directory index is not scraped.
I've just a small nit. Once applied we can get the patch merged.
Again thanks a lot for all the great work! And in case of questions feel free to join us in the https://chat.mozilla.org/#/room/#webdriver:mozilla.org channel. It's not directly related to this project but it's the place where we all hang out.
…mozilla#313) - re-arrange if-else
…rectory' into issue-313-tinderbox-timestamp-directory
|
Done moving if-else @whimboo |
whimboo
requested changes
May 8, 2024
…mozilla#313) - revert comment removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #313 - Don't retrieve Tinderbox directory listing when timestamp is provided @whimboo