ci: Remove some things from env
#2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `CARGO_TERM_COLOR: always` is always set by `dtolnay/rust-toolchain` 2. `RUST_BACKTRACE` is better set where needed, rather than everywhere.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to e5770ce. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.149 µs 11.180 µs 11.217 µs]
change: [-0.2893% +0.0247% +0.3272%] (p = 0.89 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0189 ms 3.0286 ms 3.0399 ms]
change: [-0.4900% +0.0011% +0.4909%] (p = 1.00 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.504 µs 19.562 µs 19.643 µs]
change: [-0.9240% +0.5659% +2.9583%] (p = 0.73 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1615 ms 5.1731 ms 5.1862 ms]
change: [-0.4132% -0.0588% +0.2998%] (p = 0.75 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5407 µs 5.5689 µs 5.6037 µs]
change: [-0.6680% +0.1885% +1.0564%] (p = 0.68 > 0.05)
decode 1048576 bytes, mask 3f: Change within noise threshold. time: [1.7581 ms 1.7583 ms 1.7584 ms]
change: [-0.7802% -0.3960% -0.0837%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.436 ns 99.813 ns 100.20 ns]
change: [+0.3418% +0.8125% +1.3228%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.54 ns 117.93 ns 118.33 ns]
change: [-0.2896% +0.5661% +1.1963%] (p = 0.14 > 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [116.95 ns 117.30 ns 117.76 ns]
change: [-0.0026% +0.6181% +1.1692%] (p = 0.03 < 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [98.487 ns 98.668 ns 98.872 ns]
change: [+0.0087% +1.3208% +2.7561%] (p = 0.05 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.39 ms 111.45 ms 111.50 ms]
change: [+0.1081% +0.3117% +0.4404%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.5836 µs 5.8242 µs 6.1091 µs]
change: [+0.2536% +6.0290% +14.469%] (p = 0.10 > 0.05)
transfer/pacing-false/varying-seeds: 💔 Performance has regressed. time: [43.620 ms 43.712 ms 43.811 ms]
change: [+4.4422% +4.7713% +5.0971%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💔 Performance has regressed. time: [44.111 ms 44.191 ms 44.274 ms]
change: [+4.9164% +5.1703% +5.4247%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💔 Performance has regressed. time: [43.902 ms 43.975 ms 44.054 ms]
change: [+4.8947% +5.1570% +5.4164%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💔 Performance has regressed. time: [43.904 ms 43.958 ms 44.013 ms]
change: [+4.1757% +4.4095% +4.6309%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [881.00 ms 890.50 ms 900.31 ms]
thrpt: [111.07 MiB/s 112.30 MiB/s 113.51 MiB/s]
change:
time: [-1.1351% +0.4059% +1.9583%] (p = 0.60 > 0.05)
thrpt: [-1.9207% -0.4042% +1.1481%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [300.40 ms 302.50 ms 304.63 ms]
thrpt: [32.827 Kelem/s 33.058 Kelem/s 33.288 Kelem/s]
change:
time: [-0.9306% +0.0414% +1.0571%] (p = 0.94 > 0.05)
thrpt: [-1.0460% -0.0414% +0.9393%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.121 ms 34.285 ms 34.469 ms]
thrpt: [29.011 elem/s 29.167 elem/s 29.307 elem/s]
change:
time: [-0.8044% -0.0585% +0.7298%] (p = 0.88 > 0.05)
thrpt: [-0.7245% +0.0585% +0.8109%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.6193 s 1.6362 s 1.6533 s]
thrpt: [60.485 MiB/s 61.119 MiB/s 61.755 MiB/s]
change:
time: [-2.9185% -1.3939% +0.1244%] (p = 0.08 > 0.05)
thrpt: [-0.1243% +1.4136% +3.0062%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
- Coverage 93.34% 93.33% -0.02%
==========================================
Files 114 114
Lines 36908 36897 -11
Branches 36908 36897 -11
==========================================
- Hits 34451 34436 -15
- Misses 1675 1681 +6
+ Partials 782 780 -2 ☔ View full report in Codecov by Sentry. |
mxinden
reviewed
Jan 10, 2025
mxinden
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CARGO_TERM_COLOR: alwaysis always set bydtolnay/rust-toolchainRUST_BACKTRACEis better set where needed, rather than everywhere.