deps(common/log): drop env_logger's auto-color and regex features #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozilla#2291 added additional formatting to our log output via `env_logger`'s `auto-color` feature. The `auto-color` feature adds the `is-terminal` crate dependency. `is-terminal` depends on `hermit-abi` `v0.4`. Pulling latest Neqo `v0.12.0` into mozilla-central adds `is-terminal` and `hermit-abi` `v0.4.0` to the Firefox dependency tree. In order to keep our dependency footprint low, I suggest not enabling the two `env-logger` features.
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 108fb8d. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2373 +/- ##
==========================================
- Coverage 95.31% 95.29% -0.02%
==========================================
Files 114 114
Lines 36856 36850 -6
Branches 36856 36850 -6
==========================================
- Hits 35128 35116 -12
- Misses 1724 1728 +4
- Partials 4 6 +2 ☔ View full report in Codecov by Sentry. |
|
Can we condition them on |
|
@larseggert I don't think hiding these dependencies behind a feature flag will resolve the issue. See same scenario we faced in the past:
|
|
Ah yes. Too bad. I kinda liked the color, but easy upstreaming is more important. |
mxinden
commented
Jan 20, 2025
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
larseggert
approved these changes
Jan 20, 2025
|
🎉 with mozilla/mtu#74 and this patch, we are down to the following changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2291 added additional formatting to our log output via
env_logger'sauto-colorfeature. Theauto-colorfeature adds theis-terminalcrate dependency.is-terminaldepends onhermit-abiv0.4.Pulling latest Neqo
v0.12.0into mozilla-central addsis-terminalandhermit-abiv0.4.0to the Firefox dependency tree.In order to keep our dependency footprint low, I suggest not enabling the two
env-loggerfeatures.@larseggert thoughts? Alternatively I can also audit the two dependencies and then introduce them into Firefox. That said, is it worth it?