fix: Fix for #2147

[larseggert]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (7a25920) to head (eda047a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2386      +/-   ##
==========================================
- Coverage   95.30%   95.29%   -0.02%     
==========================================
  Files         114      114              
  Lines       36850    36850              
  Branches    36850    36850              
==========================================
- Hits        35121    35117       -4     
- Misses       1725     1727       +2     
- Partials        4        6       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Failed Interop Tests

None ❓

All results

Succeeded Interop Tests

None ❓

Unsupported Interop Tests

None ❓

[github-actions]

Benchmark results

Performance differences relative to 7a25920.

decode 4096 bytes, mask ff: No change in performance detected.

       time:   [11.850 µs 11.886 µs 11.929 µs]
       change: [-0.2093% +0.2751% +0.8186%] (p = 0.30 > 0.05)
Found 17 outliers among 100 measurements (17.00%)

3 (3.00%) low mild

2 (2.00%) high mild

12 (12.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.

       time:   [2.8827 ms 2.8905 ms 2.8999 ms]
       change: [-0.7446% -0.2564% +0.2179%] (p = 0.30 > 0.05)
Found 8 outliers among 100 measurements (8.00%)

1 (1.00%) low mild

7 (7.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.

       time:   [19.769 µs 19.820 µs 19.876 µs]
       change: [-0.6069% -0.1272% +0.3528%] (p = 0.61 > 0.05)
Found 21 outliers among 100 measurements (21.00%)

3 (3.00%) low severe

3 (3.00%) low mild

15 (15.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.

       time:   [5.0716 ms 5.0828 ms 5.0953 ms]
       change: [-0.4666% -0.1291% +0.2054%] (p = 0.47 > 0.05)
Found 14 outliers among 100 measurements (14.00%)

14 (14.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.

       time:   [6.8969 µs 6.9216 µs 6.9535 µs]
       change: [-0.4042% +0.1202% +0.6332%] (p = 0.67 > 0.05)
Found 21 outliers among 100 measurements (21.00%)

4 (4.00%) low severe

6 (6.00%) low mild

1 (1.00%) high mild

10 (10.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.

       time:   [1.4155 ms 1.4222 ms 1.4293 ms]
       change: [-0.3314% +0.2642% +0.8624%] (p = 0.41 > 0.05)
Found 10 outliers among 100 measurements (10.00%)

2 (2.00%) high mild

8 (8.00%) high severe

coalesce_acked_from_zero 1+1 entries: No change in performance detected.

       time:   [98.439 ns 98.668 ns 98.905 ns]
       change: [-1.1170% -0.4522% +0.1369%] (p = 0.17 > 0.05)
Found 6 outliers among 100 measurements (6.00%)

6 (6.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.

       time:   [116.49 ns 116.89 ns 117.34 ns]
       change: [-0.4846% +0.0507% +0.5112%] (p = 0.85 > 0.05)
Found 13 outliers among 100 measurements (13.00%)

1 (1.00%) high mild

12 (12.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.

       time:   [116.39 ns 116.97 ns 117.62 ns]
       change: [-0.4049% +0.1752% +0.8007%] (p = 0.57 > 0.05)
Found 15 outliers among 100 measurements (15.00%)

4 (4.00%) low mild

1 (1.00%) high mild

10 (10.00%) high severe

coalesce_acked_from_zero 1000+1 entries: Change within noise threshold.

       time:   [97.902 ns 98.103 ns 98.346 ns]
       change: [-0.0046% +0.8983% +1.8310%] (p = 0.05 < 0.05)
Found 11 outliers among 100 measurements (11.00%)

4 (4.00%) high mild

7 (7.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.

       time:   [111.49 ms 111.54 ms 111.58 ms]
       change: [-0.1829% -0.1192% -0.0582%] (p = 0.00 < 0.05)
Found 16 outliers among 100 measurements (16.00%)

1 (1.00%) low severe

5 (5.00%) low mild

10 (10.00%) high mild

SentPackets::take_ranges: No change in performance detected.

       time:   [5.5108 µs 5.7178 µs 5.9434 µs]
       change: [-2.0284% +1.1566% +4.6132%] (p = 0.49 > 0.05)
Found 9 outliers among 100 measurements (9.00%)

4 (4.00%) high mild

5 (5.00%) high severe

transfer/pacing-false/varying-seeds: Change within noise threshold.

       time:   [40.381 ms 40.462 ms 40.543 ms]
       change: [-1.4777% -1.2086% -0.9462%] (p = 0.00 < 0.05)
Found 6 outliers among 100 measurements (6.00%)

2 (2.00%) low mild

4 (4.00%) high mild

transfer/pacing-true/varying-seeds: Change within noise threshold.

       time:   [40.681 ms 40.752 ms 40.827 ms]
       change: [-1.6901% -1.4731% -1.2688%] (p = 0.00 < 0.05)
Found 2 outliers among 100 measurements (2.00%)

2 (2.00%) high mild

transfer/pacing-false/same-seed: Change within noise threshold.

       time:   [40.331 ms 40.389 ms 40.448 ms]
       change: [-1.6643% -1.4707% -1.2679%] (p = 0.00 < 0.05)
Found 1 outliers among 100 measurements (1.00%)

1 (1.00%) high mild

transfer/pacing-true/same-seed: Change within noise threshold.

       time:   [40.251 ms 40.308 ms 40.365 ms]
       change: [-1.8368% -1.6245% -1.4222%] (p = 0.00 < 0.05)

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected.

       time:   [907.35 ms 917.96 ms 928.84 ms]
       thrpt:  [107.66 MiB/s 108.94 MiB/s 110.21 MiB/s]
change:
       time:   [-0.1403% +1.6170% +3.3250%] (p = 0.07 > 0.05)
       thrpt:  [-3.2180% -1.5913% +0.1405%]
Found 1 outliers among 100 measurements (1.00%)

1 (1.00%) high mild

1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.

       time:   [316.66 ms 318.56 ms 320.50 ms]
       thrpt:  [31.201 Kelem/s 31.391 Kelem/s 31.580 Kelem/s]
change:
       time:   [-0.3775% +0.5896% +1.5616%] (p = 0.23 > 0.05)
       thrpt:  [-1.5375% -0.5861% +0.3790%]
Found 3 outliers among 100 measurements (3.00%)

3 (3.00%) high mild

1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected.

       time:   [34.260 ms 34.453 ms 34.662 ms]
       thrpt:  [28.850  elem/s 29.025  elem/s 29.189  elem/s]
change:
       time:   [-0.3382% +0.3467% +1.0925%] (p = 0.35 > 0.05)
       thrpt:  [-1.0807% -0.3455% +0.3393%]
Found 12 outliers among 100 measurements (12.00%)

3 (3.00%) low mild

3 (3.00%) high mild

6 (6.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold.

       time:   [1.7205 s 1.7384 s 1.7562 s]
       thrpt:  [56.942 MiB/s 57.525 MiB/s 58.121 MiB/s]
change:
       time:   [+0.0186% +1.5524% +3.1131%] (p = 0.05 < 0.05)
       thrpt:  [-3.0191% -1.5286% -0.0186%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client	Server	CC	Pacing	MTU	Mean [ms]	Min [ms]	Max [ms]
gquiche	gquiche			1504	583.2 ± 134.5	509.3	850.2
neqo	gquiche	reno	on	1504	745.1 ± 30.6	723.6	829.0
neqo	gquiche	reno		1504	757.2 ± 15.2	734.6	785.0
neqo	gquiche	cubic	on	1504	772.9 ± 22.8	734.9	818.7
neqo	gquiche	cubic		1504	734.3 ± 18.6	709.9	755.6
msquic	msquic			1504	147.2 ± 66.7	92.4	285.4
neqo	msquic	reno	on	1504	212.4 ± 8.5	200.5	225.8
neqo	msquic	reno		1504	240.6 ± 72.4	206.4	443.1
neqo	msquic	cubic	on	1504	239.0 ± 58.1	210.9	421.1
neqo	msquic	cubic		1504	222.0 ± 10.5	202.3	237.9
gquiche	neqo	reno	on	1504	721.8 ± 167.6	543.2	1127.7
gquiche	neqo	reno		1504	666.5 ± 84.9	546.6	784.3
gquiche	neqo	cubic	on	1504	675.4 ± 82.3	567.0	801.5
gquiche	neqo	cubic		1504	685.6 ± 80.6	565.8	810.3
msquic	neqo	reno	on	1504	481.4 ± 11.8	465.7	494.9
msquic	neqo	reno		1504	475.7 ± 14.9	442.1	491.6
msquic	neqo	cubic	on	1504	517.3 ± 95.8	461.9	727.6
msquic	neqo	cubic		1504	472.6 ± 7.9	457.1	486.4
neqo	neqo	reno	on	1504	439.7 ± 15.9	421.6	469.6
neqo	neqo	reno		1504	493.9 ± 115.8	428.4	765.2
neqo	neqo	cubic	on	1504	460.0 ± 8.4	447.1	470.0
neqo	neqo	cubic		1504	439.8 ± 7.1	432.2	452.9

⬇️ Download logs