-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta revision number not available for title #204
Comments
Interesting. We are getting the version via http://mxr.mozilla.org/mozilla-central/source/browser/base/content/aboutDialog.xul#48
Because of that and no other instance of the beta revision in the application package, I'm not sure how to find out the beta index. |
The General Data section of about:telemetry shows the variable |
Hi! Telemetry's
... where
It's OK to me to implement with |
@benplumley, thanks for the Telemetry hint! 👍 |
Great to see that AppConstants.jsm module. It would indeed be great to get it added. |
* Increased the size of the Customize Title bar window * Optimized the order of the Customize Title bar Variables * Added Customize Title bar Variable Application Title and Version * Added Customize Title bar Variable Application Display Version * Added Customize Title bar Variable Application Version Pretty * Added Customize Title bar Variable Application Update Channel * Added Customize Title bar Variable Application Update Channel Pretty (Release, ESR, beta, Aurora, Nighty, Default) * Added Customize Title bar Variable Application Beta Revision (only filled when applicable), fixing mozilla#204 * Added Customize Title bar Variable Application Version and Channel * Removed Gecko Build Identifier, since it used PlatformBuildID, just like XUL Platform Build Identifier * Removed Gecko Version, since it used PlatformVersion, just like XUL Platform Version
@xabolcs, this looks like an easy thing to get added now that we have experience with AppConstants.jsm. Do you think we could fold this into the 3.9 release? |
Sure we could, but please see the conversation in PR #212, starting with my comment! |
* Increased the size of the Customize Title bar window * Optimized the order of the Customize Title bar Variables * Added Customize Title bar Variable Application Title and Version * Added Customize Title bar Variable Application Display Version * Added Customize Title bar Variable Application Version Pretty * Added Customize Title bar Variable Application Update Channel * Added Customize Title bar Variable Application Update Channel Pretty (Release, ESR, beta, Aurora, Nighty, Default) * Added Customize Title bar Variable Application Beta Revision (only filled when applicable), fixing mozilla#204 * Added Customize Title bar Variable Application Version and Channel * Removed Gecko Build Identifier, since it used PlatformBuildID, just like XUL Platform Build Identifier * Removed Gecko Version, since it used PlatformVersion, just like XUL Platform Version
* Increased the size of the Customize Title bar window * Optimized the order of the Customize Title bar Variables * Added Customize Title bar Variable Application Title and Version * Added Customize Title bar Variable Application Display Version * Added Customize Title bar Variable Application Version Pretty * Added Customize Title bar Variable Application Update Channel * Added Customize Title bar Variable Application Update Channel Pretty (Release, ESR, beta, Aurora, Nighty, Default) * Added Customize Title bar Variable Application Beta Revision (only filled when applicable), fixing mozilla#204 * Added Customize Title bar Variable Application Version and Channel * Removed Gecko Build Identifier, since it used PlatformBuildID, just like XUL Platform Build Identifier * Removed Gecko Version, since it used PlatformVersion, just like XUL Platform Version
I'm currently implementing the added customize title bar options into the WebExtension. In the XUL-based extension the beta version was retreived using:
In Firefox 57 @kyoshino Do you know a way to retreive the beta version in the WebExtension? |
@UtiluMark, try with WebExtensions Experiments! |
Is this bug still open? |
Yes it is. And checking again it should basically be fixed at the WebExtension API level. There is https://bugzilla.mozilla.org/show_bug.cgi?id=1389751 open for exactly that problem. |
On the beta channel, the version number (as shown in About Firefox) is eg 47.0b2. However, none of NTT's variables for window name show the "b2" part. They only show "47.0".
The text was updated successfully, but these errors were encountered: