Added customize title bar options #212

UtiluMark · 2016-08-23T17:53:29Z

Increased the size of the Customize Title bar window
Optimized the order of the Customize Title bar Variables
Added Customize Title bar Variable Application Title and Version
Added Customize Title bar Variable Application Display Version
Added Customize Title bar Variable Application Version Pretty
Added Customize Title bar Variable Application Update Channel
Added Customize Title bar Variable Application Update Channel Pretty (Release, ESR, beta, Aurora, Nighty, Default)
Added Customize Title bar Variable Application Beta Version (only filled when applicable), fixing Beta revision number not available for title #204
Added Customize Title bar Variable Application Version and Channel
Removed Gecko Build Identifier, since it used PlatformBuildID, just like XUL Platform Build Identifier
Removed Gecko Version, since it used PlatformVersion, just like XUL Platform Version

whimboo · 2016-08-25T15:22:50Z

This PR will be one more fix for issue #188.

@UtiluMark, the commits in this PR look weird and I would like that you rebase against latest master. I see a lot of them which are not related to this PR at all. So please make sure that only the relevant ones are included in this PR, thanks.

UtiluMark · 2016-08-26T14:40:07Z

@whimboo Rebased against latest master, so there is now only one commit.

xabolcs · 2016-08-28T21:48:22Z

extension/chrome/content/nightly.js

@@ -2,6 +2,8 @@
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

+Components.utils.import("resource://gre/modules/AppConstants.jsm");


This will pollute global namespace.

Moved AppConstants import to where it is used: b568576
(AppConstants.MOZ_APP_VERSION_DISPLAY even works without the import)

If it works without the import then I vote against importing it. :)

Removed the AppConstants import completely: 9ae50b7

xabolcs · 2016-08-28T21:56:41Z

Added Customize Title bar Variable Application Beta Revision (only filled when applicable), fixing Beta revision number not available for title #204

May I ask to open a separate PR fixing #204 only?

UtiluMark · 2016-08-28T22:22:58Z

@xabolcs The Beta Revision is only used in Customize Title bar Variables that were newly added in this PR, no current Customize Title bar Variables were changed. I don't think #204 should be fixed by changing current Customize Title bar Variables.

xabolcs · 2016-08-28T23:14:14Z

@UtiluMark, would you mind thinking about to refactor this titlebar (and it's helpers) customization stuff into it's own ~~jsm~~ module?

It's OK to me if you leave it as is. But a nice refactor around titlebar customization is welcome!

whimboo · 2016-08-29T13:24:34Z

I would also prefer a minimized patch to get support for the beta version number for issue #204, so that we can make it part of the 3.9 release. Thanks.

UtiluMark · 2016-08-30T10:10:20Z

@whimboo Like I said #212 (comment) to @xabolcs, I don't think #204 can and should be fixed by changing current Customize Title bar Variables, since it's a missing feature and not a bug.
If you mean by "a minimized patch to get support for the beta version number" adding only the new Beta Revision Customize Title bar Variables from this PR through another PR, then that would still require updating the language files in that PR. Which means updating the language files twice, instead of once when done through this PR. So I think it's better to minimize the number of times the language files are updated, and just finish this PR.

* Increased the size of the Customize Title bar window * Optimized the order of the Customize Title bar Variables * Added Customize Title bar Variable Application Title and Version * Added Customize Title bar Variable Application Display Version * Added Customize Title bar Variable Application Version Pretty * Added Customize Title bar Variable Application Update Channel * Added Customize Title bar Variable Application Update Channel Pretty (Release, ESR, beta, Aurora, Nighty, Default) * Added Customize Title bar Variable Application Beta Revision (only filled when applicable), fixing mozilla#204 * Added Customize Title bar Variable Application Version and Channel * Removed Gecko Build Identifier, since it used PlatformBuildID, just like XUL Platform Build Identifier * Removed Gecko Version, since it used PlatformVersion, just like XUL Platform Version

UtiluMark · 2016-08-31T22:13:25Z

Note: If you want to test the code from this PR in a Firefox version that requires signed add-ons, you can use my signed fork.

whimboo · 2016-09-01T12:49:37Z

extension/chrome/content/nightly.js

@@ -15,20 +15,36 @@ variables: {
    return this._appInfo;
  },

+  get titleversion() { return this.tabtitle + ' - ' + this.vendor + ' ' + this.name + ' ' + this.versionchannel + ' (' + this.appbuildid + ')'; },
+  get defaulttitle() { return nightlyApp.defaultTitle; },


It would be better to review if you wouldn't have moved around existing lines. Another commit would have been good for that.

Also moving those lines would have made sense if those would be in alphabetical order now. But that is still not the case. Mind doing that?

The Title bar Variables are grouped per kind now.
I don't think an alphabetical order would provide a clear overview of the different variables with (partly) similar values (and if you would sort alphabetically, which row would you sort alphabetically? Variable? Description? Value?).

Common identifiers could be used first eg. titleDefault, titleTab. But whatever we use then other related variables like for tabs in this case are no longer grouped together. So whatever you do it will not be perfect.

whimboo · 2016-09-01T13:04:26Z

As you can see there are lots of changes in this PR. I don't see that we can fold this into the 3.9 release. So lets move it to 3.10.

* Used the short way to get app.update.channel * Changed beta revision to beta version

UtiluMark · 2016-09-23T11:30:51Z

@whimboo @xabolcs @benplumley I've just released a new version with the latest changes from this PR, so if you want to test the latest code from this PR in a Firefox version that requires signed add-ons, you can use my signed fork.

Is there anything you would like to be added, removed or changed in this PR?

benplumley · 2016-09-29T10:47:38Z

@UtiluMark looks good, though I'm only able to test in release at the moment. I like the fine-grained variables, I'll likely use the signed fork until this is merged. Thanks!

UtiluMark · 2017-05-15T22:53:05Z

@whimboo @xabolcs @benplumley Since this PR was moved to 3.10 #212 (comment), which is about to be released, while this PR isn't merged yet: can this PR be merged, or is there anything you would like to be added, removed or changed in this PR?

whimboo · 2017-05-16T08:23:11Z

We have to get 3.10 out to unblock users from using it. It currently doesn't work for Nightly. Also I don't have the time to dive into this PR again for the moment. Sorry.

UtiluMark · 2017-06-20T15:30:35Z

@whimboo @xabolcs @benplumley If you want to test the latest code from this PR with the latest changes from 3.10 in Nightly or a Firefox version that requires signed add-ons: I've just released a new version of my signed fork.

xabolcs · 2017-10-11T09:28:40Z

@UtiluMark, may I close this PR or do you want to rebase it?

UtiluMark · 2017-10-11T09:52:24Z

@xabolcs I was already working on it, but I had one issue, see #204 (comment).
We had found a way to retreive the beta version in the XUL-based extension, but this doesn't work in the WebExtension.
Do you know a way to retreive the beta version in the WebExtension?

whimboo · 2017-10-11T16:51:09Z

Maybe bug 1386076 could help us here. It would give us the information on which channel the user is on. But so far it's not fixed.

UtiluMark mentioned this pull request Aug 23, 2016

Port back code-changes from Utilu Nightly Tester Tools 3.7.1.1 #188

Closed

UtiluMark closed this Aug 26, 2016

UtiluMark force-pushed the titlebar-options branch from 21610a0 to f7e9426 Compare August 26, 2016 14:23

UtiluMark reopened this Aug 26, 2016

xabolcs reviewed Aug 28, 2016
View reviewed changes

xabolcs mentioned this pull request Aug 29, 2016

Beta revision number not available for title #204

Open

UtiluMark force-pushed the titlebar-options branch from 76c5408 to f9ed8a1 Compare August 31, 2016 10:17

UtiluMark force-pushed the titlebar-options branch from f9ed8a1 to d116fa8 Compare August 31, 2016 20:58

whimboo reviewed Sep 1, 2016
View reviewed changes

Short way to get app.update.channel + beta version

62bc0d3

* Used the short way to get app.update.channel * Changed beta revision to beta version

xabolcs force-pushed the master branch from 5377c91 to b4e77b9 Compare May 13, 2017 23:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added customize title bar options #212

Added customize title bar options #212

UtiluMark commented Aug 23, 2016 •

edited

Loading

whimboo commented Aug 25, 2016

UtiluMark commented Aug 26, 2016

xabolcs Aug 28, 2016

UtiluMark Aug 28, 2016

xabolcs Aug 28, 2016

UtiluMark Aug 28, 2016 •

edited

Loading

xabolcs commented Aug 28, 2016

UtiluMark commented Aug 28, 2016

xabolcs commented Aug 28, 2016 •

edited

Loading

whimboo commented Aug 29, 2016

UtiluMark commented Aug 30, 2016

UtiluMark commented Aug 31, 2016 •

edited

Loading

whimboo Sep 1, 2016

whimboo Sep 1, 2016

UtiluMark Sep 2, 2016

whimboo Sep 7, 2016

whimboo commented Sep 1, 2016

UtiluMark commented Sep 23, 2016

benplumley commented Sep 29, 2016

UtiluMark commented May 15, 2017

whimboo commented May 16, 2017

UtiluMark commented Jun 20, 2017

xabolcs commented Oct 11, 2017

UtiluMark commented Oct 11, 2017

whimboo commented Oct 11, 2017

Added customize title bar options #212

Are you sure you want to change the base?

Added customize title bar options #212

Conversation

UtiluMark commented Aug 23, 2016 • edited Loading

whimboo commented Aug 25, 2016

UtiluMark commented Aug 26, 2016

xabolcs Aug 28, 2016

Choose a reason for hiding this comment

UtiluMark Aug 28, 2016

Choose a reason for hiding this comment

xabolcs Aug 28, 2016

Choose a reason for hiding this comment

UtiluMark Aug 28, 2016 • edited Loading

Choose a reason for hiding this comment

xabolcs commented Aug 28, 2016

UtiluMark commented Aug 28, 2016

xabolcs commented Aug 28, 2016 • edited Loading

whimboo commented Aug 29, 2016

UtiluMark commented Aug 30, 2016

UtiluMark commented Aug 31, 2016 • edited Loading

whimboo Sep 1, 2016

Choose a reason for hiding this comment

whimboo Sep 1, 2016

Choose a reason for hiding this comment

UtiluMark Sep 2, 2016

Choose a reason for hiding this comment

whimboo Sep 7, 2016

Choose a reason for hiding this comment

whimboo commented Sep 1, 2016

UtiluMark commented Sep 23, 2016

benplumley commented Sep 29, 2016

UtiluMark commented May 15, 2017

whimboo commented May 16, 2017

UtiluMark commented Jun 20, 2017

xabolcs commented Oct 11, 2017

UtiluMark commented Oct 11, 2017

whimboo commented Oct 11, 2017

UtiluMark commented Aug 23, 2016 •

edited

Loading

UtiluMark Aug 28, 2016 •

edited

Loading

xabolcs commented Aug 28, 2016 •

edited

Loading

UtiluMark commented Aug 31, 2016 •

edited

Loading