Add refactored Callout component, replace Call-out [fix #787] #908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the Callout, but also changes the name so it effectively removes and replaces the previous component.
The revised Callout:
This also means a Callout can replace a default centered Hero, and we can finally fully remove the Hero component.
However, since this renames/replaces a component it's a breaking change and will need a major release. We could keep the old name but I prefer it without a dash. But moreover I wanted to make the compact version a variant and not a whole component, so that would deprecate Compact Call-out anyway.
So... if we really care about gradual deprecation and keeping old components for a while to let people transition, we shouldn't change the name. But I want to change the name, and keeping the dashed and undashed names is even messier than just doing it.
CHANGELOG.md
.Issue
#787
Testing
https://demo2--mozilla-protocol.netlify.app/components/detail/callout--default
http://localhost:3000/components/detail/callout--default