feat: add job type and parent job fields to allocation metadata #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `JobType` and `ParentJob` fields to the `AllocMeta` struct in `app.go` - Added the `job_type` and `parent_job_name` fields to the `vector.toml.tmpl` file
|
This is super useful, thanks a lot. Give me some time to locally test it and get back! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mr-karan,
First, thanks for taking the time to build this! I've found it to be quite useful.
I run a lot of batch jobs via Nomad and the logging sinks tend to lose the context of the job their in. Nomad batch jobs all have a parent job. This PR adds the
JobTypeandParentJoblabels which will allow us to properly configure downstream sinks for batch jobs.JobTypeandParentJobfields to theAllocMetastruct inapp.gojob_typeandparent_job_namefields to thevector.toml.tmplfile