Add a paramter to pass extra padding around crop rect #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the crop handles to not overlap system gesture area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the CroppingPreview directly, or the cropper dialog with 0 padding, the crop handles overlap the back gestures area. This change allows the user to pass extra padding so that the crop handles do not overlap the gesture area.
I think instead of the library adding the gesture padding internally, it should be up to the user to pass the values.
For the demo to work correctly, I had to set
WindowCompat.setDecorFitsSystemWindows(window, false)in theMainActivity. OtherwiseWindowInsets.mandatorySystemGestureswill always be zero.Before padding:
before.extra.padding.mp4
After padding:
after.extra.padding.mp4