Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(mfi-v2-ui): collateral repay improvements #1022

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

chambaz
Copy link
Contributor

@chambaz chambaz commented Jan 8, 2025

  • Fix USD values in actionbox preview
  • Fallback to amountIn calculation if Jup fails on exact out

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marginfi-v2-trading ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 2:56pm
marginfi-v2-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 2:56pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
marginfi-landing-page ⬜️ Skipped (Inspect) Jan 8, 2025 2:56pm
marginfi-v2-docs ⬜️ Skipped (Inspect) Jan 8, 2025 2:56pm

Copy link

alwaysmeticulous bot commented Jan 8, 2025

✅ Meticulous spotted zero visual differences across 202 screens tested: view results.

Meticulous simulated ~4 hours of user flows but tested none of the executable lines edited in your PR. If your PR does not modify your frontend this is expected. If this is a new feature or Meticulous was recently introduced then Meticulous will generate tests to cover your code in the coming days1.

1. If you wish to increase coverage immediately you can do so by interacting with your feature on localhost.

Expected differences? Click here. Last updated for commit 01d2038. This comment will update as new commits are pushed.

@chambaz chambaz marked this pull request as ready for review January 9, 2025 13:43
@chambaz chambaz requested a review from losman0s as a code owner January 9, 2025 13:43
@chambaz chambaz merged commit 4e10b76 into main Jan 9, 2025
7 checks passed
@chambaz chambaz deleted the feat/repay-collat-improvements branch January 9, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant