Restore notifications #8
Conversation
|
Hey thanks a lot for this! Sorry it took me a while to get to it. Just to confirm, it looks like you're checking once per hour to see if there are new reviews? I'm down to merge as is, but fyi the app used to have the interval as a configurable setting. Right now all the settings UI in activity_settings.xml are marked as gone. The bottom of SettingsActivity.java has the method that gets used to setup the options, and has a list of times (I believe in minutes) that are selectable. Again I'm totally fine merging this as is to get some notification functionality back, just wanted to make sure you were aware of the original functionality. |
|
I'll look into restoring some options to this |
|
Cool! I'm totally fine if you want to re-evaluate what was done previously and come up with different configuration options than were done previously. Enable/disable may be less important now since notifications can be turned on/off from Android settings, though it would be nice to have an app setting for it as well. |
Also removed old notification system
|
Branch has been updated with the notification settings restored |
No description provided.