feat: change streams.Task interface and update to v7 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkocztorz
reviewed
Nov 2, 2023
| p.errFn(err) | ||
|
|
||
| return | ||
| if err = p.errFn(err); err != nil { |
There was a problem hiding this comment.
One thing I see here is Unlock function call is now optional but I guess its intended. The other difference is the p.errFn is now called before p.Unlock. Good, as long as you know its ok.
There was a problem hiding this comment.
Yeah, previously p.Unlock has been called before errFn, but we were always stopping the task. Currently task is supposed to continue running until you return an error from errFn.
mkocztorz
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made here:
task.OnErrornow accepts function signaturefunc(error) error, allowing to handle errors throughout the stream better than before.OnError.Shopify/saramatoIBM/saramawithkafkatests updatescachepackage as it had deprecatedpkg/v4as dependency, currently there's we have no time to reimplement cache sink, therefore it's removed in v7sqlpackage as it had data race related withdatabase/sqlusage. Hopefully we will be able to bring it back in the future.xerrorsdependencykafkasink related with errors