2.0.5.4

- Fixed a edge condition where an error would be thrown when deleting an association
msawczyn · Aug 26, 2020 · 46bac52 · 46bac52
1 parent 684c195
commit 46bac52
Show file tree

Hide file tree

Showing 17 changed files with 31 additions and 21 deletions.
diff --git a/README.md b/README.md
@@ -53,7 +53,12 @@ to <a href="https://www.jetbrains.com/?from=EFDesigner"><img src="https://msawcz
 
 ### Change Log
 
-**2.0.5.3**
+**2.0.5.4**
+   - Fixed a edge condition where an error would be thrown when deleting an association
+
+<details>
+<summary><b>2.0.5.3</b></summary>
+
    - Provide option to save diagrams as uncompressed XML to facilitate version control (in Tools/Options/Entity Framework Visual Editor)
    - Enhanced error reporting for assembly import errors
    - Assembly import can now process assemblies with more than one DbContext class

diff --git a/VSMarketplace blurb.md b/VSMarketplace blurb.md
@@ -30,6 +30,9 @@ For comprehensive documentation, please visit [the project's documentation site]
 
 **ChangeLog**
 
+**2.0.5.4**
+   - Fixed a edge condition where an error would be thrown when deleting an association
+
 **2.0.5.3**
    - **[NEW]** Provide option to save diagrams as uncompressed XML to facilitate version control (in Tools/Options/Entity Framework Visual Editor)
    - **[NEW]** Enhanced error reporting for assembly import errors

diff --git a/changelog.txt b/changelog.txt
@@ -1,3 +1,6 @@
+2.0.5.4
+   - Fixed a edge condition where an error would be thrown when deleting an association
+
 2.0.5.3
    - Provide option to save diagrams as uncompressed XML to facilitate version control (in Tools/Options/Entity Framework Visual Editor)
    - Enhanced error reporting for assembly import errors

diff --git a/dist/Sawczyn.EFDesigner.EFModel.DslPackage.vsix b/dist/Sawczyn.EFDesigner.EFModel.DslPackage.vsix
diff --git a/src/Dsl/CustomCode/Rules/AssociationDeletingRules.cs b/src/Dsl/CustomCode/Rules/AssociationDeletingRules.cs
@@ -21,7 +21,7 @@ public override void ElementDeleting(ElementDeletingEventArgs e)
 
          List<ModelAttribute> unnecessaryProperties = element.Dependent?.AllAttributes?.Where(x => x.IsForeignKeyFor == element.Id && !x.IsIdentity).ToList();
 
-         if (unnecessaryProperties?.Any() != true)
+         if (unnecessaryProperties?.Any() == true)
          {
             WarningDisplay.Show($"{element.GetDisplayText()} doesn't specify defined foreign keys. Removing foreign key attribute(s) {string.Join(", ", unnecessaryProperties.Select(x => x.GetDisplayText()))}");